Skip to content

Clarify language in BUILD.md #989

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 20, 2025
Merged

Clarify language in BUILD.md #989

merged 4 commits into from
Mar 20, 2025

Conversation

SableRaf
Copy link
Collaborator

@SableRaf SableRaf commented Mar 20, 2025

skip ci

closes #985

@SableRaf SableRaf requested a review from Stefterv March 20, 2025 13:01
BUILD.md Outdated

### Running Processing

The main task to run or debug the PDE is `app:run` this run the application with `compose desktop`
The main task to run or debug the PDE is `run`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Period (.) missing at end of sentence.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Fixed.

Copy link
Contributor

@babaissarkar babaissarkar Mar 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd also suggest mentioning the exact command. Not everyone who's building from source may understand what a gradle task means (aka there are people who may be interested in building from source solely because it gives them access to latest features).

The main task to run or debug the PDE is `run`. That means you just need to run `./gradlew run` (Linux) or `./gradlew.bat run` (Windows) to build and run Processing.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done! I'll let @Stefterv review the changes.

@Stefterv Stefterv marked this pull request as ready for review March 20, 2025 18:44
@Stefterv Stefterv added this to the 4.4.1 milestone Mar 20, 2025
@SableRaf SableRaf merged commit f168214 into main Mar 20, 2025
@Stefterv Stefterv deleted the SableRaf-patch-1 branch March 25, 2025 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't build latest checkout
3 participants