Add Windows CI + fix a bunch of bugs/tests on Windows#1657
Open
Add Windows CI + fix a bunch of bugs/tests on Windows#1657
Conversation
not closing it prevent limnoria-test from cleaning the data dir on Windows
eg. this seems to be needed for Factoids' tests to close their DB.
Otherwise, ChannelDBHandler.die() is never called because IrcCallback.die() does not call super().die() (and it can't because its parent class does not have such a method)
They are noisy on Windows every time we spawn a process (and will be on POSIX when we'll switch to the 'forkserver' method). It also seems pretty bad to run them in forked processes (with the 'fork' method), I imagine it might corrupt non-atomic files because it may cause concurrent writes; in addition to writing outdated data (if data in the main process was changed since the fork started)
progval
changed the title
lambdas are not picklable, which prevented running this in a spawned process, like `@string re` does.
Especially on Windows (and on POSIX when we'll switch from 'fork' to 'forkserver').
This fixes tests for Aka and Network on Windows
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.