-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Raytracing API rework, fence changes, utilities, advanced mapping #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
||
#include <emmintrin.h> | ||
|
||
namespace phi |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why is this public API of phi? is it used in some other lib as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
moved to phi::util
Philip-Trettner
approved these changes
Oct 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
General
arg::raytracing_pipeline_state_desc
to replace current arguments to PSO creationwchar_t
strings from the API, and most strings overalluploadTopLevelInstances
- added explicit buffer argument tocmd::update_top_level
cmd::dispatch_rays
to support arbitrary shader table buffer locationssignalFenceGPU
andwaitFenceGPU
submit
for 1) fences to wait on before, and 2) fences to signal afterwardsmapBuffer
andunmapBuffer
respectivelyarg::graphics_pipeline_state_desc
andarg::compute_pipeline_state_desc
, and PSO creation overloadsformat::none
, simplifying some API and commands (breaking)util.hh
:get_texture_size_bytes
: compute the amount of bytes a texture will require on GPUget_texture_pixel_byte_offset
: compute the offset in bytes of a pixel in GPU texture dataunswizzle_bgra_texture_data
: convert GPU-downloaded texture data in bgra format to rgbaget_hlsl_constant_buffer_offset
: helper to compute offsets in constant buffer shader structssrc/common
, renamed some helpers, removed namespacesutil::dump_hex
D3D12
cmd::barrier_uav
for UAV barriers (no Vulkan equivalent currently)Vulkan