Skip to content

Commit

Permalink
Use std::vector for allocations here. (#37714)
Browse files Browse the repository at this point in the history
Unsure why clang-tidy complains here, however the allocation
is effectively a dynamic array, so used vector here instead.
  • Loading branch information
andy31415 authored Feb 23, 2025
1 parent a373044 commit c82226b
Showing 1 changed file with 5 additions and 3 deletions.
8 changes: 5 additions & 3 deletions src/setup_payload/tests/TestAdditionalDataPayload.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -93,10 +93,12 @@ CHIP_ERROR ParseAdditionalDataPayload(const char * additionalDataPayload, size_t
return CHIP_ERROR_INVALID_STRING_LENGTH;
}
size_t additionalDataPayloadBytesLength = additionalDataPayloadLength / 2;
std::unique_ptr<uint8_t[]> additionalDataPayloadBytes(new uint8_t[additionalDataPayloadBytesLength]);

std::vector<uint8_t> additionalDataPayloadBytes;
additionalDataPayloadBytes.resize(additionalDataPayloadBytesLength);
size_t bufferSize = chip::Encoding::HexToBytes(additionalDataPayload, additionalDataPayloadLength,
additionalDataPayloadBytes.get(), additionalDataPayloadBytesLength);
return AdditionalDataPayloadParser(additionalDataPayloadBytes.get(), bufferSize).populatePayload(outPayload);
additionalDataPayloadBytes.data(), additionalDataPayloadBytesLength);
return AdditionalDataPayloadParser(additionalDataPayloadBytes.data(), bufferSize).populatePayload(outPayload);
}

class TestAdditionalDataPayload : public ::testing::Test
Expand Down

0 comments on commit c82226b

Please sign in to comment.