New chef devices - Rainsensor waterfreezedetector #37529
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review changes with Changed Files
|
|
PR #37529: Size comparison from e5a49c8 to ad293de Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
andy31415
reviewed
Feb 12, 2025
andy31415
requested changes
Feb 12, 2025
There was a problem hiding this comment.
Please build the device types and run TC_DeviceConformance.py on them and report success as part of #### Testing entry.
In particular I ran this:
python src/python_testing/TC_DeviceConformance.py --commissioning-method on-network --discriminator 3840 --passcode 20202021and rain sensor fails:
[MatterTest] 02-12 09:12:29.932 INFO [Test] test_TC_IDM_10_6 FAIL
[MatterTest] 02-12 09:12:29.933 INFO ###########################################################
[MatterTest] 02-12 09:12:29.933 INFO Problems found:
[MatterTest] 02-12 09:12:29.933 INFO ===============
[MatterTest] 02-12 09:12:29.933 INFO
Problem: ProblemSeverity.ERROR
test_name: IDM-10.2
location:
Endpoint: 0,
Cluster: 31 (0x1f) AccessControl
Attribute:1 (0x01)
problem: Attribute 0x01 is included, but is disallowed by conformance. Conformance: EXTS, implemented features:
spec_location:
[MatterTest] 02-12 09:12:29.933 INFO
Problem: ProblemSeverity.ERROR
test_name: IDM-10.2
location:
Endpoint: 0,
Cluster: 49 (0x31) NetworkCommissioning
Attribute:2 (0x02)
problem: Attribute 0x02 is included, but is disallowed by conformance. Conformance: WI | TH, implemented features: ET
spec_location:
[MatterTest] 02-12 09:12:29.933 INFO
Problem: ProblemSeverity.ERROR
test_name: IDM-10.2
location:
Endpoint: 0,
Cluster: 49 (0x31) NetworkCommissioning
Attribute:3 (0x03)
problem: Attribute 0x03 is included, but is disallowed by conformance. Conformance: WI | TH, implemented features: ET
spec_location:
[MatterTest] 02-12 09:12:29.933 INFO
Problem: ProblemSeverity.ERROR
test_name: IDM-10.2
location:
Endpoint: 0,
Cluster: 60 (0x3c) AdministratorCommissioning
Command: 1 (0x01)
problem: Command 0x01 is included, but disallowed by conformance. Conformance: BC, implemented features:
spec_location:
[MatterTest] 02-12 09:12:29.933 INFO
Problem: ProblemSeverity.ERROR
test_name: IDM-10.2
location:
Endpoint: 1,
Cluster: 47 (0x2f) PowerSource
Attribute:15 (0x0f)
problem: Attribute 0x0f is required, but is not present on the DUT. Conformance: BAT, implemented features: BAT,RECHG
spec_location:
[MatterTest] 02-12 09:12:29.933 INFO
Problem: ProblemSeverity.ERROR
test_name: IDM-10.3
location:
Endpoint: 0,
Cluster: 40 (0x28) BasicInformation
Attribute:65533 (0xfffd)
problem: Revision found on cluster (2) does not match revision listed in the spec (4)
spec_location:
[MatterTest] 02-12 09:12:29.933 INFO
Problem: ProblemSeverity.ERROR
test_name: IDM-10.3
location:
Endpoint: 0,
Cluster: 48 (0x30) GeneralCommissioning
Attribute:65533 (0xfffd)
problem: Revision found on cluster (1) does not match revision listed in the spec (2)
spec_location:
[MatterTest] 02-12 09:12:29.933 INFO
Problem: ProblemSeverity.ERROR
test_name: IDM-10.3
location:
Endpoint: 1,
Cluster: 3 (0x03) Identify
Attribute:65533 (0xfffd)
problem: Revision found on cluster (2) does not match revision listed in the spec (5)
spec_location:
[MatterTest] 02-12 09:12:29.933 INFO
Problem: ProblemSeverity.ERROR
test_name: IDM-10.3
location:
Endpoint: 1,
Cluster: 4 (0x04) Groups
Attribute:65533 (0xfffd)
problem: Revision found on cluster (3) does not match revision listed in the spec (4)
spec_location:
[MatterTest] 02-12 09:12:29.933 INFO
Problem: ProblemSeverity.ERROR
test_name: IDM-10.3
location:
Endpoint: 1,
Cluster: 47 (0x2f) PowerSource
Attribute:65533 (0xfffd)
problem: Revision found on cluster (1) does not match revision listed in the spec (3)
spec_location:
[MatterTest] 02-12 09:12:29.933 INFO
Problem: ProblemSeverity.ERROR
test_name: IDM-10.5
location:
Endpoint: 1,
Cluster: 4 (0x04) Groups
problem: Extra cluster found on endpoint with device types [Descriptor.Structs.DeviceTypeStruct(deviceType=17, revision=1), Descriptor.Structs.DeviceTypeStruct(deviceType=68, revision=1)]
spec_location:
[MatterTest] 02-12 09:12:29.933 INFO
Problem: ProblemSeverity.ERROR
test_name: IDM-10.6
location:
Endpoint: 0,
Cluster: 29 (0x1d) Descriptor
problem: Expected Device type revision for device type 22 Root Node on endpoint 0 does not match revision on DUT. Expected: 3 DUT: 1
spec_location:
[MatterTest] 02-12 09:12:29.933 INFO ###########################################################
[MatterTest] 02-12 09:12:29.933 INFO Summary for test class TC_DeviceConformance: Error 0, Executed 4, Failed 4, Passed 0, Requested 4, Skipped 0
|
PR #37529: Size comparison from 522876c to 67f4d66 Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
PR #37529: Size comparison from 94a47ad to bd54927 Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
PR #37529: Size comparison from 33aec35 to cdce3b6 Full report (42 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, psoc6, qpg, stm32, telink, tizen)
|
|
PR #37529: Size comparison from 33aec35 to 743fdc6 Full report (69 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nxp, psoc6, qpg, stm32, telink, tizen)
|
andy31415
approved these changes
Feb 19, 2025
|
PR #37529: Size comparison from 0b67ce2 to 4ed8ccb Full report (7 builds for cc32xx, qpg, stm32, tizen)
|
|
PR #37529: Size comparison from 8464e5f to 2b0e96d Full report (64 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, tizen)
|
|
PR #37529: Size comparison from 40979b4 to 825d9d9 Full report (64 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, tizen)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing
Conformance tests -