Skip to content

Add test for custom InstaScale controller image support #124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 9, 2023
Merged

Conversation

astefanutti
Copy link
Contributor

This follows up #120, and adds a test case covering the new controllerImage field of the InstaScale resource.

@openshift-ci openshift-ci bot requested review from jbusche and MichaelClifford June 7, 2023 08:14
@astefanutti
Copy link
Contributor Author

/assign @tedhtchang

/cc @jbusche

@jbusche
Copy link
Collaborator

jbusche commented Jun 8, 2023

I tested the PR on my OpenShift 4.12.18 cluster, and it worked fine. Can still sub out the InstaScale image when/as needed. When I edit the instascale CR, the CodeFlare operator log catches the change and updates the InstaScale deployment:

2023-06-08T16:31:03-07:00	INFO	Merging	{"diff": "{\"spec\":{\"template\":{\"spec\":{\"$setElementOrder/containers\":[{\"name\":\"instascale\"}],\"containers\":[{\"image\":\"quay.io/project-codeflare/instascale-controller:v0.0.2\",\"name\":\"instascale\"}]}}}}"}
2023-06-08T16:31:03-07:00	INFO	Updating	{"name": "opendatahub/instascale-instascale", "type": "apps/v1, Kind=Deployment"}
2023-06-08T16:31:03-07:00	INFO	Finished applying InstaScale Resources

Copy link
Collaborator

@jbusche jbusche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openshift-ci
Copy link

openshift-ci bot commented Jun 8, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jbusche

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Jun 8, 2023
@tedhtchang
Copy link
Member

thanks @astefanutti /lgtm

@openshift-merge-robot openshift-merge-robot merged commit bb1ce80 into project-codeflare:main Jun 9, 2023
@astefanutti astefanutti deleted the pr-05 branch June 9, 2023 06:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants