Skip to content

Add MCAD version variable #139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 15, 2023
Merged

Add MCAD version variable #139

merged 1 commit into from
Jun 15, 2023

Conversation

astefanutti
Copy link
Contributor

This PR adds a variable to parameterise the version of the MCAD dependency.

It follows up #116, so the version used to retrieve the MCAD CRDs is not hard-coded anymore.

It'll also be used for #114.

@astefanutti astefanutti marked this pull request as ready for review June 14, 2023 16:37
@openshift-ci
Copy link

openshift-ci bot commented Jun 14, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@astefanutti
Copy link
Contributor Author

/assign @anishasthana @KPostOffice @sutaakar

Copy link
Contributor

@anishasthana anishasthana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sutaakar
Copy link
Contributor

@astefanutti
Copy link
Contributor Author

Would it be possible to update also https://github.com/project-codeflare/codeflare-operator/blob/main/config/internal/mcad/deployment.yaml.tmpl#L28 ?

I've intentionally omitted it here, as it's the purpose of #114, that'll be similar to #120.

Copy link
Contributor

@sutaakar sutaakar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@openshift-ci openshift-ci bot added the lgtm label Jun 15, 2023
Copy link
Contributor

@anishasthana anishasthana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci
Copy link

openshift-ci bot commented Jun 15, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: anishasthana, sutaakar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 02e14b5 into project-codeflare:main Jun 15, 2023
@astefanutti astefanutti deleted the pr-08 branch June 16, 2023 06:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants