-
Notifications
You must be signed in to change notification settings - Fork 58
Add MCAD version variable #139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add MCAD version variable #139
Conversation
Skipping CI for Draft Pull Request. |
/assign @anishasthana @KPostOffice @sutaakar |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we also update https://github.com/project-codeflare/codeflare-operator/blob/main/CONTRIBUTING.md?plain=1#L34 as part of this?
@sutaakar fyi^^
Would it be possible to update also https://github.com/project-codeflare/codeflare-operator/blob/main/config/internal/mcad/deployment.yaml.tmpl#L28 ? |
I've intentionally omitted it here, as it's the purpose of #114, that'll be similar to #120. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: anishasthana, sutaakar The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This PR adds a variable to parameterise the version of the MCAD dependency.
It follows up #116, so the version used to retrieve the MCAD CRDs is not hard-coded anymore.
It'll also be used for #114.