Skip to content

fix: Update MCAD version when installing CRDs #152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 5, 2023
Merged

fix: Update MCAD version when installing CRDs #152

merged 1 commit into from
Jul 5, 2023

Conversation

astefanutti
Copy link
Contributor

The update of the MCAD version when installing CRDs is missing.

This PR applies the MCAD version the same way it's done when deploying the operator.

Fixes #151.

@openshift-ci openshift-ci bot requested review from jbusche and tedhtchang June 27, 2023 08:11
@astefanutti
Copy link
Contributor Author

/assign @jbusche

@astefanutti astefanutti mentioned this pull request Jun 28, 2023
7 tasks
@KPostOffice
Copy link
Collaborator

/approve

Just tested 👍🏻

@openshift-ci openshift-ci bot added the approved label Jul 5, 2023

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@openshift-ci openshift-ci bot removed the lgtm label Jul 5, 2023
Copy link
Contributor

@anishasthana anishasthana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci
Copy link

openshift-ci bot commented Jul 5, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: anishasthana, KPostOffice, sutaakar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [KPostOffice,anishasthana]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit e04fbfa into project-codeflare:main Jul 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

make install failing with MCAD crd issue
6 participants