Skip to content

Adjust Makefile versions before building operator image #177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 10, 2023

Conversation

sutaakar
Copy link
Contributor

@sutaakar sutaakar commented Jul 10, 2023

Fixes #175, #172

@openshift-ci
Copy link

openshift-ci bot commented Jul 10, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@sutaakar sutaakar marked this pull request as ready for review July 10, 2023 13:40
@sutaakar sutaakar requested a review from anishasthana July 10, 2023 13:40
Copy link
Contributor

@anishasthana anishasthana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change look good to me.
/lgtm

@openshift-ci
Copy link

openshift-ci bot commented Jul 10, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: anishasthana

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit cd43ff5 into project-codeflare:main Jul 10, 2023
@sutaakar sutaakar deleted the versions-fix branch July 10, 2023 14:33
@sutaakar sutaakar mentioned this pull request Jul 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Release automation publish operator image with old default image versions
3 participants