Enable TestMNISTRayClusterSDK test #234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/lgtm |
anishasthana
force-pushed
the
enable-raycluster-e2e
branch
from
8f07a84 to
6c47853
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: anishasthana The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue link
Resolves #215
What changes have been made
The TestMNISTRayClusterSDK e2e test previously only ran on OpenShift clusters as the codeflare-SDK did not support other kubernetes distributions. Now that this PR has been merged and the codeflare-SDK dependency updated we can re-enable the test by removing the relevant call to skip the test.
Verification steps
Run e2e tests on a non openshift cluster and make sure that TestMNISTRayClusterSDK is passing. This test is currently skipped until project-codeflare/codeflare-sdk#271 is merged.
Checks