Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

get_current_namespace broken due to authentication change #289

Open
carsonmh opened this issue Aug 8, 2023 · 1 comment
Open

get_current_namespace broken due to authentication change #289

carsonmh opened this issue Aug 8, 2023 · 1 comment
Assignees
@carsonmh

Comments

@carsonmh
Copy link
Contributor

carsonmh commented Aug 8, 2023

Currently get_current_namespace searches for a namespace file if there is an api_client present. The problem is, with the new authentication implementation, oc login isn't invoked, meaning that this namespace file may not be present. So its better to just use kubernetes API to search for namespace
@carsonmh carsonmh self-assigned this Aug 8, 2023
@Maxusmusti
Copy link
Collaborator

Would be good to sync up with @Bobbins228 on this as well

@carsonmh carsonmh mentioned this issue Aug 8, 2023
Closed
4 tasks
@carsonmh carsonmh moved this from Todo to Ready For Review in Project CodeFlare Sprint Board Aug 8, 2023
@carsonmh carsonmh mentioned this issue Aug 11, 2023
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@carsonmh carsonmh

Labels
None yet
Projects
Project CodeFlare Sprint Board
Status: Ready For Review
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix get_current_namespace project-codeflare/codeflare-sdk
2 participants
@Maxusmusti @carsonmh