Skip to content

fix get_current_namespace #294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

fix get_current_namespace #294

wants to merge 1 commit into from

Conversation

carsonmh
Copy link
Contributor

@carsonmh carsonmh commented Aug 8, 2023

Issue link

closes #289

What changes have been made

  • get_current_namespace checks both serviceaccount and kubeconfig for current namespace. Removed api_config_handler check because sometimes you have api_client but want to check kubeconfig instead of serviceaccount.

Verification steps

  • Try logging in with TokenAuthentication after calling oc logout and call get_current_namespace. This will give you your current namespace. If you do this on the old get_current_namespace it will say namespace not found.

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • Testing is not required for this change

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 8, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign michaelclifford for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@carsonmh carsonmh closed this by deleting the head repository Aug 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant