CLI Define and Submit job commands #280
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-merge-robot
added
the
needs-rebase
openshift-merge-robot
removed
the
needs-rebase
carsonmh
force-pushed
the
cli-update
branch
2 times, most recently
from
ffda563 to
18a2aa5
Compare
MichaelClifford
requested changes
Aug 9, 2023
MichaelClifford
approved these changes
Aug 10, 2023
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: MichaelClifford The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue link
closes #276
What changes have been made
define jobandsubmit jobcommands. Allows user to define and submit jobs from the terminalcodeflare define jobtakes in the same parameters that the SDK defines and creates a DDPJobDefinition in the user's .codeflare folder.codeflare submit jobsubmits a job based on the job name. The user can either submit to a raycluster or just to k8s.Verification steps
codeflare submit job --helporcodeflare define job --helpto see how each command works and then can run each commandpytest -v tests/unit_test.pyChecks