add and implement option to not generate appwrapper in a Cluster #295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichaelClifford
requested changes
Aug 10, 2023
Co-authored-by: Michael Clifford <[email protected]>
src/codeflare_sdk/cluster/cluster.py
Outdated
| @@ -137,6 +144,9 @@ def down(self): | |||
| associated with the cluster. | |||
| """ | |||
| namespace = self.config.namespace | |||
| if self.app_wrapper_yaml is None: | |||
| self.app_wrapper_yaml = self.create_app_wrapper() | |||
There was a problem hiding this comment.
Is there another way to get self.app_wrapper_name here other than generating the appwrapper yaml. Seems unnecessary to generate the appwrapper yaml just to delete the resource.
MichaelClifford
approved these changes
Aug 10, 2023
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: MichaelClifford The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue link
Closes #278
What changes have been made
Changed Cluster definition so it optionally doesn't create an appwrapper. Changed
Cluster.from_k8_cluster_objectso it doesn't create an appwrapper. So whenget_clusteris called, no appwrapper is generatedVerification steps
Use
get_clusterand it won't generate an appwrapper. Use Cluster object normally and it will.Checks