Skip to content

Fix output logs by switching to kind-cluster context #501

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

ChristianZaccaria
Copy link
Collaborator

@ChristianZaccaria ChristianZaccaria commented Apr 4, 2024

Issue link

Jira: https://issues.redhat.com/browse/RHOAIENG-5131

What changes have been made

This was previously attempted to be fixed, however when the e2e test fails, the step to Switch to kind-cluster context is skipped due to previous step failure.

  • With this change, the step to switch context will always be made, enabling to print component logs.

As seen/tested here: https://github.com/project-codeflare/codeflare-sdk/actions/runs/8560772513/job/23460511229?pr=495

Verification steps

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • Testing is not required for this change

@openshift-ci openshift-ci bot requested review from dimakis and Maxusmusti April 4, 2024 20:36
Copy link
Contributor

openshift-ci bot commented Apr 4, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign dimakis for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@dgrove-oss
Copy link
Collaborator

/lgtm -- I've made the same fix in my various branches.

@ChristianZaccaria
Copy link
Collaborator Author

@dgrove-oss awesome, thanks for reviewing!

@Bobbins228 Bobbins228 merged commit a06cf4f into project-codeflare:main Apr 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants