Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SDK Info Rework (status, details, wait, etc.) #63

Merged
merged 8 commits into from
Feb 23, 2023
Merged

Conversation

Maxusmusti
Copy link
Collaborator

@Maxusmusti Maxusmusti commented Feb 13, 2023

SDK Info Rework:

  • New all-encpompassing cluster.status() method
  • New cluster.details() method
  • New cluster.wait_ready() method
  • New CodeFlareStatus.STARTING status
  • Functionsget_current_namespace(), list_all_clusters(), and list_all_queued() now all function as intended
  • A ton of bugfixes and error-handling for both regular use and edge-cases (not logged in, login expired, no resources created yet, resource failure, cluster setup in-progress, etc.)
  • A LOT more testing (up to 95%)
  • Improved messaging on both expected unexpected results

Tied to issue #33

@Maxusmusti Maxusmusti self-assigned this Feb 13, 2023
@Maxusmusti Maxusmusti marked this pull request as ready for review February 22, 2023 23:12
@MichaelClifford
Copy link
Collaborator

@Maxusmusti Looks good 👍 Just had a couple comments about function names before we merge. Let me know what you think.

@MichaelClifford
Copy link
Collaborator

@Maxusmusti also, do we want to update the notebooks showing how to use these new features in this PR? Or included it in a later PR?

@Maxusmusti
Copy link
Collaborator Author

@Maxusmusti also, do we want to update the notebooks showing how to use these new features in this PR? Or included it in a later PR?

I can include those in a separate PR that updates the documentation and prepares for new release

Copy link
Collaborator

@MichaelClifford MichaelClifford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants