-
Notifications
You must be signed in to change notification settings - Fork 53
Add UI table with Cluster specs and action buttons #681
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add UI table with Cluster specs and action buttons #681
Conversation
c2f1d31
to
967348b
Compare
967348b
to
25777e8
Compare
4832462
to
d4ce271
Compare
ed242d1
to
5c582c9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few nits looks good other than that. I will physically test this now but I just have another annoying nit on top of all of this.
Can you add head comments for all of the new functions of the wdgets.py file? Similar to what you have done here.
4cd1ff4
to
130328b
Compare
@ChristianZaccaria can you run the |
c21efee
to
4070c59
Compare
@ChristianZaccaria The ray image is fixed now so E2E should pass. Can you rebase? |
…ation of Cluster Object, and bug fixes
4070c59
to
891038c
Compare
Remaining enhancements will be made in the scope of the Jira "Refactor ipywidgets into a separate module" from the This includes:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Bobbins228 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Issue link
Jira: https://issues.redhat.com/browse/RHOAIENG-12526
What changes have been made
cpu requests
andcpu limits
.TODO:
view_clusters
to guided-notebooks by default? - GivenCluster Up
andCluster Down
widgets will appear by default, I think it's a good idea to immediately encourage the user to use (and be aware) of this feature. We don't need to trigger the buttons fortest-guided-notebooks
tests as it will be covered byui-notebooks-test
tests. Only the expected outputs would have to be updated.TODO
left inwidgets.py
file. [ ✔️ ]Verification steps
Install the codeflare-sdk and import:
There are several items to test which include:
Checks