Separate auth from cluster methods #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichaelClifford
force-pushed
the
seperateAuth
branch
from
e83b4a9 to
52dc956
Compare
Maxusmusti
reviewed
Mar 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is aimed at making working with OpenShift environments a bit more user friendly by separating the authentication process from the the cluster object. Previously we automatically logged users in and out along with the cluster.up and cluster.down commands. This introduced the problem of needing to get a new token each time they restarted their ray cluster, since it also logged them out of their OpenShift cluster. Now users can use auth.login and auth.logout to control cluster access. cluster.up and cluster.down no longer force the authentication action, and the authentication object is no longer required in the cluster config.
(This is an update of #66)