Skip to content

[Part-1] Refactor k8s related code into a separate module #692

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 2, 2024
Merged

[Part-1] Refactor k8s related code into a separate module #692

merged 1 commit into from
Oct 2, 2024

Conversation

varshaprasad96
Copy link
Contributor

Issue link

What changes have been made

This commit is first of the chain in refactoring the cluster/ package. This moves the auth package into a separate module.

The unit tests have not been refactored based on the discussion in: here. A separate PR will be created to refactor all the tests.

Verification steps

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • Testing is not required for this change

@Bobbins228 Bobbins228 added the test-guided-notebooks Run PR check to verify Guided notebooks label Oct 1, 2024
ChristianZaccaria
ChristianZaccaria reviewed Oct 1, 2024
View reviewed changes
Copy link
Collaborator

@ChristianZaccaria ChristianZaccaria left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm great work!

Bobbins228
Bobbins228 requested changes Oct 1, 2024
View reviewed changes
@Bobbins228
Copy link
Contributor

I think we are missing imports for __kube_api_error_handling in tests/upgrades/raycluster_sdk_upgrade_sleep_test.py and tests/upgrades/raycluster_sdk_upgrade_test.py

@varshaprasad96
[Part-1] Refactor k8s related code into a separate module
f493678 
This commit is first of the chain in refactoring the cluster/
package.
ChristianZaccaria
ChristianZaccaria reviewed Oct 2, 2024
View reviewed changes
Copy link
Collaborator

@ChristianZaccaria ChristianZaccaria left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm I used an imports diagnosis tool for verification.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 2, 2024
Bobbins228
Bobbins228 reviewed Oct 2, 2024
View reviewed changes
Copy link
Contributor

@Bobbins228 Bobbins228 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm /approve

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Oct 2, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Bobbins228, ChristianZaccaria, Ygnas

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 2, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Oct 2, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Bobbins228, ChristianZaccaria, Ygnas

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 730b0ed into project-codeflare:main Oct 2, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ygnas Ygnas Ygnas approved these changes

@Bobbins228 Bobbins228 Bobbins228 approved these changes

@ChristianZaccaria ChristianZaccaria ChristianZaccaria approved these changes

@Maxusmusti Maxusmusti Awaiting requested review from Maxusmusti

@MichaelClifford MichaelClifford Awaiting requested review from MichaelClifford

Assignees

@Ygnas Ygnas

@Bobbins228 Bobbins228

@ChristianZaccaria ChristianZaccaria

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. test-guided-notebooks Run PR check to verify Guided notebooks
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@varshaprasad96 @Bobbins228 @Ygnas @ChristianZaccaria