Skip to content

e2e test for heterogenous cluster #718

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

Ygnas
Copy link
Contributor

@Ygnas Ygnas commented Oct 18, 2024

Issue link

https://issues.redhat.com/browse/RHOAIENG-13430

What changes have been made

Added new e2e test for heterogenous cluster

Verification steps

kueue pull this and do:
IMAGE_REGISTRY=quay.io/<username>/kueues make image-local-push deploy

Don't forget to change <username>

After building and installing new kueue test can be run by:

Openshift: poetry run pytest -v -s ./tests/e2e -m 'openshift'

Local kind: poetry run pytest -v -s ./tests/e2e/heterogeneous_clusters_kind_test.py

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • Testing is not required for this change

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 18, 2024
Copy link

codecov bot commented Oct 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.08%. Comparing base (e4b13fc) to head (77f7f30).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #718   +/-   ##
=======================================
  Coverage   94.08%   94.08%           
=======================================
  Files          36       36           
  Lines        2401     2401           
=======================================
  Hits         2259     2259           
  Misses        142      142           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Ygnas Ygnas force-pushed the heterogeneous-clusters branch 4 times, most recently from df0c780 to ec8f602 Compare October 21, 2024 12:17
@Ygnas Ygnas force-pushed the heterogeneous-clusters branch from ec8f602 to dffb238 Compare October 21, 2024 14:24
@Ygnas Ygnas marked this pull request as ready for review October 21, 2024 14:56
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 21, 2024
@Ygnas Ygnas force-pushed the heterogeneous-clusters branch 2 times, most recently from 684e5fa to 0584b39 Compare October 21, 2024 16:38
Copy link
Contributor

@jiripetrlik jiripetrlik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 22, 2024
@Ygnas Ygnas force-pushed the heterogeneous-clusters branch from 0584b39 to 2a7ffed Compare October 22, 2024 09:01
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Oct 22, 2024
@Ygnas Ygnas force-pushed the heterogeneous-clusters branch from 2a7ffed to d82353a Compare October 22, 2024 09:31
@Srihari1192
Copy link
Contributor

@Ygnas we may need e2e test for heterogenous cluster to support for openshift clusters aswell to run on downstream testing

@Ygnas Ygnas force-pushed the heterogeneous-clusters branch from d82353a to d77d513 Compare October 22, 2024 15:14
@Ygnas
Copy link
Contributor Author

Ygnas commented Oct 22, 2024

@Ygnas we may need e2e test for heterogenous cluster to support for openshift clusters aswell to run on downstream testing

Added a test for openshift cluster. Just not sure about the labels as these ones are specifically for the kind cluster. While testing I added these labels to nodes in my openshift cluster and test passed. Of course still needing the new kueue built

@Ygnas Ygnas force-pushed the heterogeneous-clusters branch 2 times, most recently from 01f6bed to 2fcd048 Compare October 22, 2024 16:05
@Ygnas Ygnas requested a review from jiripetrlik October 25, 2024 09:32
@Ygnas Ygnas force-pushed the heterogeneous-clusters branch from bee0bec to 25aed63 Compare October 28, 2024 10:04
@Ygnas Ygnas added the e2e label Oct 28, 2024
@Ygnas Ygnas force-pushed the heterogeneous-clusters branch from 25aed63 to 65d190f Compare October 29, 2024 09:25
@openshift-ci openshift-ci bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Oct 29, 2024
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Oct 29, 2024
@Ygnas Ygnas force-pushed the heterogeneous-clusters branch 2 times, most recently from d330985 to d350770 Compare October 29, 2024 16:59
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 29, 2024
@Ygnas Ygnas dismissed Srihari1192’s stale review October 29, 2024 17:28

Dismissing as it was resolved.

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Oct 29, 2024
@Ygnas Ygnas force-pushed the heterogeneous-clusters branch from f07c73a to d350770 Compare October 29, 2024 17:42
@Ygnas Ygnas removed the e2e label Oct 29, 2024
@Ygnas Ygnas force-pushed the heterogeneous-clusters branch 2 times, most recently from 4d91a27 to 01e5964 Compare October 29, 2024 18:04
@Ygnas Ygnas force-pushed the heterogeneous-clusters branch from 01e5964 to 77f7f30 Compare October 29, 2024 18:16
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 29, 2024
Copy link
Contributor

openshift-ci bot commented Oct 29, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jiripetrlik, KPostOffice

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 62cd27b into project-codeflare:main Oct 29, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants