-
Notifications
You must be signed in to change notification settings - Fork 53
e2e test for heterogenous cluster #718
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
e2e test for heterogenous cluster #718
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #718 +/- ##
=======================================
Coverage 94.08% 94.08%
=======================================
Files 36 36
Lines 2401 2401
=======================================
Hits 2259 2259
Misses 142 142 ☔ View full report in Codecov by Sentry. |
df0c780
to
ec8f602
Compare
ec8f602
to
dffb238
Compare
684e5fa
to
0584b39
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
0584b39
to
2a7ffed
Compare
2a7ffed
to
d82353a
Compare
@Ygnas we may need e2e test for heterogenous cluster to support for openshift clusters aswell to run on downstream testing |
d82353a
to
d77d513
Compare
Added a test for openshift cluster. Just not sure about the labels as these ones are specifically for the kind cluster. While testing I added these labels to nodes in my openshift cluster and test passed. Of course still needing the new kueue built |
01f6bed
to
2fcd048
Compare
bee0bec
to
25aed63
Compare
25aed63
to
65d190f
Compare
d330985
to
d350770
Compare
f07c73a
to
d350770
Compare
4d91a27
to
01e5964
Compare
01e5964
to
77f7f30
Compare
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jiripetrlik, KPostOffice The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
62cd27b
into
project-codeflare:main
Issue link
https://issues.redhat.com/browse/RHOAIENG-13430
What changes have been made
Added new e2e test for heterogenous cluster
Verification steps
kueue pull this and do:
IMAGE_REGISTRY=quay.io/<username>/kueues make image-local-push deploy
After building and installing new kueue test can be run by:
Openshift:
poetry run pytest -v -s ./tests/e2e -m 'openshift'
Local kind:
poetry run pytest -v -s ./tests/e2e/heterogeneous_clusters_kind_test.py
Checks