-
Notifications
You must be signed in to change notification settings - Fork 53
Enhance error handling in _kube_api_error_handling #762
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhance error handling in _kube_api_error_handling #762
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #762 +/- ##
==========================================
- Coverage 93.05% 93.04% -0.01%
==========================================
Files 36 36
Lines 2403 2402 -1
==========================================
- Hits 2236 2235 -1
Misses 167 167 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
2346c09
to
a30c994
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
a30c994
to
8481faa
Compare
8481faa
to
adc1ad7
Compare
src/codeflare_sdk/common/kubernetes_cluster/kube_api_helpers.py
Outdated
Show resolved
Hide resolved
adc1ad7
to
979ec8c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One nit and I am happy with merging this
src/codeflare_sdk/common/kubernetes_cluster/kube_api_helpers.py
Outdated
Show resolved
Hide resolved
979ec8c
to
d89bfb8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Bobbins228 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
003a287
into
project-codeflare:main
Issue link
https://issues.redhat.com/browse/RHOAIENG-15225
What changes have been made
Enhanced error messages to give more detailed errors to our users so that they have more information to feed the RHOAI administrators.
Verification steps
To test this install new codeflare-sdk from this PR, you could try deleteting non existent cluster, creating 2 clusters with same name, trying to create appwrapper.
Errors appear like this:
Checks