Add test coverage to validate the functionality of the get_cluster function #775
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
the
do-not-merge/work-in-progress
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #775 +/- ##
=======================================
Coverage 93.04% 93.04%
=======================================
Files 36 36
Lines 2402 2402
=======================================
Hits 2235 2235
Misses 167 167 ☔ View full report in Codecov by Sentry. |
Srihari1192
force-pushed
the
RHOAIENG-16104
branch
from
a12bb00 to
c955fe0
Compare
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
openshift-ci
bot
requested review from
Fiona-Waters and
franciscojavierarceo
Srihari1192
force-pushed
the
RHOAIENG-16104
branch
2 times, most recently
from
60b07f8 to
6ecaa99
Compare
Ygnas
approved these changes
Nov 28, 2024
jiripetrlik
reviewed
Dec 3, 2024
Srihari1192
force-pushed
the
RHOAIENG-16104
branch
from
6ecaa99 to
de24c11
Compare
Srihari1192
force-pushed
the
RHOAIENG-16104
branch
from
de24c11 to
3e69aee
Compare
jiripetrlik
approved these changes
Dec 4, 2024
Bobbins228
requested changes
Dec 4, 2024
|
Going to test this when my cluster is up and after the above is resolved I would be happy to merge 👍 |
Srihari1192
force-pushed
the
RHOAIENG-16104
branch
from
3e69aee to
0b8f68a
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Bobbins228, jiripetrlik, Ygnas The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
openshift-merge-bot
bot
merged commit e666e0a
into
project-codeflare:main
15 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue link
https://issues.redhat.com/browse/RHOAIENG-16104
What changes have been made
Added the test scenarios for get_cluster function to fetch cluster details and job submission
Verification steps
Testing
Run the tests mnist_raycluster_sdk_oauth_test and mnist_raycluster_sdk_kind_test.py by cloning this branch and verify newly added tests scenarios are validating correctly
poetry run pytest -v -s ./tests/e2e/mnist_raycluster_sdk_oauth_test.pyChecks