Skip to content

Use Python3.11 in SDK Workflows by default #786

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 2, 2025

Conversation

Ygnas
Copy link
Contributor

@Ygnas Ygnas commented Dec 19, 2024

Issue link

https://issues.redhat.com/browse/RHOAIENG-16118

What changes have been made

Use Python3.11 in SDK Workflows by default, and as 3.9 is still supported updated unit test to work with both 3.9 and 3.11 (maybe it was unnecessary?)

Verification steps

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • Testing is not required for this change

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 19, 2024
Copy link

codecov bot commented Dec 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.33%. Comparing base (814efb4) to head (065151d).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #786   +/-   ##
=======================================
  Coverage   90.32%   90.33%           
=======================================
  Files          23       23           
  Lines        1344     1345    +1     
=======================================
+ Hits         1214     1215    +1     
  Misses        130      130           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Ygnas Ygnas force-pushed the RHOAIENG-16118 branch 3 times, most recently from 7430308 to 7853b9d Compare December 19, 2024 19:21
@Ygnas Ygnas changed the title [WIP] Rhoaieng 16118 Use Python3.11 in SDK Workflows by default Dec 19, 2024
@Ygnas Ygnas marked this pull request as ready for review December 19, 2024 19:25
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 19, 2024
@Ygnas Ygnas requested review from KPostOffice and ChristianZaccaria and removed request for Fiona-Waters December 19, 2024 19:25
Copy link
Contributor

@Bobbins228 Bobbins228 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 20, 2024
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 20, 2024
Copy link
Contributor

@Bobbins228 Bobbins228 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm /approve

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jan 2, 2025
Copy link
Contributor

@Bobbins228 Bobbins228 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 2, 2025
@Bobbins228 Bobbins228 removed the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 2, 2025
@Bobbins228 Bobbins228 removed the lgtm Indicates that a PR is ready to be merged. label Jan 2, 2025
Copy link
Contributor

@Bobbins228 Bobbins228 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 2, 2025
Copy link
Contributor

openshift-ci bot commented Jan 2, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Bobbins228, KPostOffice

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [Bobbins228,KPostOffice]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 2, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit 36f578d into project-codeflare:main Jan 2, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants