Skip to content

task(RHOAIENG-22446): Updated OWNERS with Ray Team #822

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

chipspeak
Copy link
Contributor

@chipspeak chipspeak commented Apr 14, 2025

Issue link

Jira Issue

What changes have been made

OWNERS file updated with new Training Ray team members

Verification steps

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • Testing is not required for this change

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 14, 2025
Copy link

codecov bot commented Apr 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.40%. Comparing base (c311665) to head (58d2005).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #822   +/-   ##
=======================================
  Coverage   92.40%   92.40%           
=======================================
  Files          23       23           
  Lines        1396     1396           
=======================================
  Hits         1290     1290           
  Misses        106      106           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@chipspeak chipspeak marked this pull request as ready for review April 14, 2025 16:20
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 14, 2025
@openshift-ci openshift-ci bot requested review from astefanutti and pmccarthy April 14, 2025 16:20
Copy link
Member

@szaher szaher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci openshift-ci bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Apr 15, 2025
@chipspeak chipspeak requested a review from kryanbeane April 15, 2025 07:22
Copy link

@pmccarthy pmccarthy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Fiona-Waters
Copy link
Contributor

/lgtm
/approve

Copy link
Contributor

openshift-ci bot commented Apr 15, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Fiona-Waters, kryanbeane, pmccarthy, szaher

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [Fiona-Waters,pmccarthy,szaher]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Fiona-Waters
Copy link
Contributor

/override e2e/kubernetes

Copy link
Contributor

openshift-ci bot commented Apr 15, 2025

@Fiona-Waters: /override requires failed status contexts, check run or a prowjob name to operate on.
The following unknown contexts/checkruns were given:

  • e2e/kubernetes

Only the following failed contexts/checkruns were expected:

  • add-approve-lgtm-label
  • kubernetes
  • tide
  • verify-0_basic_ray
  • verify-1_cluster_job_client
  • verify-2_basic_interactive
  • verify-3_widget_example
  • verify-local_interactive
  • verify-ray_job_client

If you are trying to override a checkrun that has a space in it, you must put a double quote on the context.

In response to this:

/override e2e/kubernetes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@Fiona-Waters
Copy link
Contributor

/override kubernetes

Copy link
Contributor

openshift-ci bot commented Apr 15, 2025

@Fiona-Waters: Overrode contexts on behalf of Fiona-Waters: kubernetes

In response to this:

/override kubernetes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@Fiona-Waters
Copy link
Contributor

/override tide

Copy link
Contributor

openshift-ci bot commented Apr 15, 2025

@Fiona-Waters: Overrode contexts on behalf of Fiona-Waters: tide

In response to this:

/override tide

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-merge-bot openshift-merge-bot bot merged commit d109bb7 into project-codeflare:main Apr 15, 2025
25 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants