Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates to the managed flow #5496

Merged
merged 3 commits into from
Feb 11, 2025
Merged

Updates to the managed flow #5496

merged 3 commits into from
Feb 11, 2025

Conversation

myersCody
Copy link
Contributor

Jira Ticket

Description

  1. We have an unspoken naming convention to name the file after the postgresql table whenever we use trino to populate that table. Therefore I renamed the files.
  2. Additionally we were providing the wrong column name to the UI summary tables.

Testing

  1. Enable both managed unleash flags
  2. Run raw calc tests for each provider

Copy link

codecov bot commented Feb 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.1%. Comparing base (961176e) to head (a74f62f).
Report is 1 commits behind head on main.

Additional details and impacted files
@@          Coverage Diff          @@
##            main   #5496   +/-   ##
=====================================
  Coverage   94.1%   94.1%           
=====================================
  Files        371     371           
  Lines      31612   31612           
  Branches    3386    3386           
=====================================
+ Hits       29736   29743    +7     
+ Misses      1220    1215    -5     
+ Partials     656     654    -2     

@lcouzens lcouzens added the hot-fix-smoke-tests pr_check label to run minimal smoke tests for fast moving bug-fix label Feb 11, 2025
@lcouzens lcouzens enabled auto-merge (squash) February 11, 2025 09:47
@lcouzens lcouzens merged commit d79f09f into main Feb 11, 2025
14 checks passed
@lcouzens lcouzens deleted the gcp_fix branch February 11, 2025 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hot-fix-smoke-tests pr_check label to run minimal smoke tests for fast moving bug-fix smokes-required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants