Skip to content

Pass search_state object to SearchService instead of params hash #3591

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Pass search_state object to SearchService instead of params hash #3591

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion app/controllers/concerns/spotlight/search_helper.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,10 +3,15 @@
module Spotlight
# ...
module SearchHelper
# @param [Hash] user_params the query parameters used to reconstitute the search state
# from saved searches. If not provided, will use the search_state from the view context
# or an empty hash if that is not available.
# @return [Object] An instance of the configured search service
def search_service(user_params = respond_to?(:search_state, true) ? search_state.to_h : {})
state = Blacklight::SearchState.new(user_params, blacklight_config)
klass = respond_to?(:search_service_class) ? search_service_class : Blacklight::SearchService

klass.new(config: blacklight_config, user_params:, **search_service_context)
klass.new(config: blacklight_config, search_state: state, **search_service_context)
end

# @return [Hash] a hash of context information to pass through to the search service
Expand Down