Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

StripTrailingHostDot: Expose new configuration option to enable Envoy removal of trailing dot on hostnames #6792

Merged
merged 3 commits into from
Feb 13, 2025

Add missing changelog file for the PR 6792

3ef268b
Select commit
Loading
Failed to load commit list.
Merged

StripTrailingHostDot: Expose new configuration option to enable Envoy removal of trailing dot on hostnames #6792

Add missing changelog file for the PR 6792
3ef268b
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Feb 13, 2025 in 0s

80.70% (+0.00%) compared to 39c7cb9

View this Pull Request on Codecov

80.70% (+0.00%) compared to 39c7cb9

Details

Codecov Report

Attention: Patch coverage is 94.73684% with 1 line in your changes missing coverage. Please review.

Project coverage is 80.70%. Comparing base (39c7cb9) to head (3ef268b).

Files with missing lines Patch % Lines
cmd/contour/serve.go 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #6792   +/-   ##
=======================================
  Coverage   80.70%   80.70%           
=======================================
  Files         131      131           
  Lines       19805    19816   +11     
=======================================
+ Hits        15983    15993   +10     
- Misses       3532     3533    +1     
  Partials      290      290           
Files with missing lines Coverage Δ
cmd/contour/servecontext.go 84.37% <100.00%> (+0.03%) ⬆️
internal/contourconfig/contourconfiguration.go 98.18% <100.00%> (+0.01%) ⬆️
internal/envoy/v3/listener.go 98.50% <100.00%> (+<0.01%) ⬆️
internal/xdscache/v3/listener.go 91.64% <100.00%> (+0.07%) ⬆️
pkg/config/parameters.go 87.69% <100.00%> (+0.03%) ⬆️
cmd/contour/serve.go 21.91% <0.00%> (-0.03%) ⬇️