Receive/refresh keys in parallel #17
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you rebase all of your PRs to pick up the CI fix? Thanks! |
desultory
force-pushed
the
parallel-fetch
branch
from
9256cf7 to
c300820
Compare
|
Also, needs a rebase. |
desultory
force-pushed
the
parallel-fetch
branch
2 times, most recently
from
3790168 to
fe47306
Compare
eli-schwartz
reviewed
Feb 5, 2025
getuto
Outdated
| @@ -159,14 +159,19 @@ if [[ ! -d ${GNUPGHOME} ]] ; then | |||
|
|
|||
| # TODO: keys.openpgp.org lacks a UID for our keys, need to verify email | |||
| for keyserver in "${mykeyservers[@]}" ; do | |||
| gpg ${QUIET_GPG} --batch --keyserver "${keyserver}" --recv-keys ${myrelkeys} || true | |||
| einfo "Importing release engineering keys from: ${keyserver}" | |||
There was a problem hiding this comment.
This is adding unconditional status messages. Currently getuto only prints the major action being done (initializing, or updating, the keyring as a whole). I'm of two minds about this change, but either way, it deserves to be a distinct commit with distinct rationale, not "do it in parallel".
getuto
Outdated
| @@ -159,14 +159,19 @@ if [[ ! -d ${GNUPGHOME} ]] ; then | |||
|
|
|||
| # TODO: keys.openpgp.org lacks a UID for our keys, need to verify email | |||
| for keyserver in "${mykeyservers[@]}" ; do | |||
| gpg ${QUIET_GPG} --batch --keyserver "${keyserver}" --recv-keys ${myrelkeys} || true | |||
| einfo "Importing release engineering keys from: ${keyserver}" | |||
| gpg ${QUIET_GPG} --batch --keyserver "${keyserver}" --recv-keys ${myrelkeys} || true & | |||
There was a problem hiding this comment.
Using & means that we inherently discard the exit status -- and wait without any options always returns true, not the exit status of the failed command. So it's really a replacement for || true...
desultory
force-pushed
the
parallel-fetch
branch
from
fe47306 to
f1d2a95
Compare
Signed-off-by: Zen <[email protected]>
Signed-off-by: Zen <[email protected]>
desultory
force-pushed
the
parallel-fetch
branch
from
f1d2a95 to
a3a96e8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should cut the runtime in half