[prometheus-smartctl-exporter] use serviceAccountName helper function where service account is referenced#6900
Merged
zeritti merged 1 commit intoMay 14, 2026
Conversation
…referenced Signed-off-by: Ben Webster <benhwebster@gmail.com>
zeritti
approved these changes
May 9, 2026
zeritti
left a comment
zeritti
left a comment
Contributor
There was a problem hiding this comment.
Thank you, @benhwebster, for your PR, LGTM.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
When setting a service account name, resources such as the daemonset and rolebinding do not utilize it, causing problems as the chart creates the service account with the set name, but the daemonset and rolebinding continue to use the hardcoded default of the chart fullname which does not exist.
Which issue this PR fixes
Special notes for your reviewer
Checklist
[prometheus-couchdb-exporter])