[kube-prometheus-stack] avoid duplicate Thanos image key#6901
Merged
jkroepke merged 2 commits intoMay 11, 2026
Merged
Conversation
Zakharden
requested review from
GMartinez-Sisti,
QuentinBisson,
Xtigyro,
andrewgkew,
gianrubio,
gkarthiks and
jkroepke
as code owners
Zakharden
force-pushed
the
fix/kps-thanos-image-duplicate-key
branch
from
699e331 to
1cf20ea
Compare
Member
|
please increase the chart version |
Contributor
Author
|
Bumped the kube-prometheus-stack chart version in 238a610 |
Signed-off-by: Zakhar Dvurechensky <72825626+Zakharden@users.noreply.github.com>
Signed-off-by: Zakhar Dvurechensky <72825626+Zakharden@users.noreply.github.com>
Zakharden
force-pushed
the
fix/kps-thanos-image-duplicate-key
branch
from
238a610 to
2a70df1
Compare
jkroepke
approved these changes
May 11, 2026
1 task
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6886.
What this PR does
This avoids rendering
prometheus.prometheusSpec.thanos.imagetwice in the generated Prometheus custom resource.The template already renders
thanos.imageexplicitly. The generic ThanostoYamlblock now omitsimage, the same way it already omitsobjectStorageConfigandsecretProviderClass.Validation
thanos.imagekey withhelm templatethanos.imageobjectStorageConfig.existingSecretstill renders underthanoshelm lint charts/kube-prometheus-stack --kube-version 1.35.4 --set prometheus.prometheusSpec.thanos.image=quay.io/thanos/thanos:v0.41.0 --set grafana.enabled=false --set kubeStateMetrics.enabled=false --set nodeExporter.enabled=false --set windowsMonitoring.enabled=falsegit diff --check HEAD~1 HEAD