chore: align go.mod go version#1257
Closed
joaoestrela wants to merge 1 commit intoprometheus-community:masterfrom
Closed
chore: align go.mod go version#1257joaoestrela wants to merge 1 commit intoprometheus-community:masterfrom
joaoestrela wants to merge 1 commit intoprometheus-community:masterfrom
Conversation
Signed-off-by: Joāo Estrela <joao.estrela@coralogix.com>
Contributor
|
This is not correct. The Since Go 1.24 is still supported by upstream Go, we continue to support building with Go >= 1.24.0. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Update the Go version in
go.modfrom 1.24.0 to 1.25 to align with the CI build configuration.Motivation
The CI workflows (
.github/workflows/ci.yml,.github/workflows/golangci-lint.yml) and build configuration (.promu.yml) already use Go 1.25, butgo.modwas still specifying Go 1.24.0. This PR fixes the inconsistency.Changes
go.modGo directive from1.24.0to1.25Testing
go mod tidyruns without issues