Skip to content

Add stat_wal and stat_io collectors - #1445

Open
JimStavr wants to merge 2 commits into
prometheus-community:masterfrom
JimStavr:master
Open

JimStavr wants to merge 2 commits into
prometheus-community:masterfrom
JimStavr:master

Conversation

@JimStavr

Copy link
Copy Markdown

We are using pg_stat_wal and pg_stat_io metrics by generating the stats manually via cronjob that executes a python script every minute in our Postgres VM, and shipped to prometheus via node exporter's textfile collector.

Since they are super useful on our prod postgres monitoring i took the initiative to add them as collectors in this exporter so they can be included in a future release if they are considered useful from the community.

Collectors added:

  • stat_io disabled by default as it can cause high cardinality, so i let the user decide to enable it or not
  • stat_wal enabled by default

I am not so familiar with this exporter, so thank you for your time and let me know for comments after reviewing.

Signed-off-by: JimStavr <stavjim85@gmail.com>
@yoav-katz

Copy link
Copy Markdown

I would love to see this merge!
We are looking for a way to see wal generation rate

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants