Repository navigation
Conversation
Signed-off-by: JimStavr <stavjim85@gmail.com>
|
I would love to see this merge! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We are using
pg_stat_walandpg_stat_iometrics by generating the stats manually via cronjob that executes a python script every minute in our Postgres VM, and shipped to prometheus via node exporter's textfile collector.Since they are super useful on our prod postgres monitoring i took the initiative to add them as collectors in this exporter so they can be included in a future release if they are considered useful from the community.
Collectors added:
stat_iodisabled by default as it can cause high cardinality, so i let the user decide to enable it or notstat_walenabled by defaultI am not so familiar with this exporter, so thank you for your time and let me know for comments after reviewing.