Skip to content

fix #547 #914

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 8 commits into from
Closed

fix #547 #914

wants to merge 8 commits into from

Conversation

mblp
Copy link

@mblp mblp commented Sep 16, 2023

No description provided.

@mblp
Copy link
Author

mblp commented Sep 16, 2023

fix two issue #1794 and #547

@mblp mblp mentioned this pull request Sep 16, 2023
Closed
@SuperQ
Copy link
Contributor

SuperQ commented Sep 17, 2023

This needs a DCO sign-off. You can use git commit -s --amend to add it.

Andrey Kozlov and others added 7 commits September 17, 2023 18:23
fix prometheus-community#547
96089dc 
Signed-off-by: Andrey Kozlov <[email protected]>
Merge branch 'pg_repl-error' of github.com:mblp/postgres_exporter int…
65251b8 
…o pg_repl-error
@mblp
Merge branch 'master' into pg_repl-error
987bc50
@divergentdave
Fix cross-compilation command in README.md (prometheus-community#903)
a80facf 
Signed-off-by: David Cook <[email protected]>
Signed-off-by: Andrey Kozlov <[email protected]>
@IamLuksha
fix pg_replication_lag_seconds (prometheus-community#895)
be2a326 
Signed-off-by: Vladimir Luksha <[email protected]>
Co-authored-by: Vladimir Luksha <[email protected]>
Signed-off-by: Andrey Kozlov <[email protected]>
fix prometheus-community#547
11cfc43 
Signed-off-by: Andrey Kozlov <[email protected]>
Merge branch 'pg_repl-error' of github.com:mblp/postgres_exporter int…
a5f7d69 
…o pg_repl-error
@saz
Copy link
Contributor

saz commented May 17, 2024

@mblp Are you still interested in getting your PR merged? If not, I'd like to take care of this issue

@nickaein
Copy link

nickaein commented Jun 2, 2024

@saz Does this MR fixed #547?

This MR has been inactive for a quite while. Considering our need for a postgres_exporter tailored for Postgres 16, we might patch and build a custom version. If you're able to complete this MR and push it to the master branch, that would be fantastic.

@nickaein nickaein mentioned this pull request Jun 10, 2024
Open
@mblp
Copy link
Author

mblp commented Jun 19, 2024 •
edited
Loading

@saz
I'll be glad if someone takes care of it. Unfortunately, I don't have time to figure out the correct design of MR.

@saz
Copy link
Contributor

saz commented Jun 20, 2024

@nickaein LGTM. Maybe there's a new issue introduced, but I'd rather fix the ones I'm aware of, and the PR does exactly that.

@mblp Thanks, I'll do a new PR and will mention, that it's based on your work.

@saz saz mentioned this pull request Jun 20, 2024
Merged
@michael-todorovic michael-todorovic mentioned this pull request Aug 30, 2024
Closed
@scanterog
Copy link

What are we missing to get this merged?

@SuperQ
Copy link
Contributor

SuperQ commented Aug 30, 2024

DCO to start.

@saz
Copy link
Contributor

saz commented Aug 30, 2024

@SuperQ @scanterog See PR #1048

@sysadmind
Copy link
Contributor

Merged via #1048

@sysadmind sysadmind closed this Sep 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@mblp @SuperQ @saz @nickaein @scanterog @sysadmind @divergentdave @IamLuksha