Skip to content

feat: use slog and add debuging logs#346

Open
yuvaldekel wants to merge 47 commits into
prometheus-community:mainfrom
yuvaldekel:add-logging
Open

feat: use slog and add debuging logs#346
yuvaldekel wants to merge 47 commits into
prometheus-community:mainfrom
yuvaldekel:add-logging

Conversation

@yuvaldekel

@yuvaldekel yuvaldekel commented Mar 16, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

This PR introduces a switch to slog library, and add debug logging to the proxy server to make it easier to troubleshoot requests.
The PR Introduce two new flags log.level and log.format. Use --help to view their usage.
The PR resolves #336 issue.

yuvaldekel and others added 14 commits March 16, 2026 23:01
@yuvaldekel
refactor(several): switch to klog
1364929 
Signed-off-by: Yuval Dekel <yuvddd05@gmail.com>
@yuvaldekel
feat(go.mod go.sum): add klog
9a95c88 
Signed-off-by: Yuval Dekel <yuvddd05@gmail.com>
@yuvaldekel
feat(main.go): add klog custom format
76f9ed2 
Signed-off-by: Yuval Dekel <yuvddd05@gmail.com>
@yuvaldekel
fix(main.go): change slog opts var name
f2e7b29 
Signed-off-by: Yuval Dekel <yuvddd05@gmail.com>
@yuvaldekel
fead(routes.go): logging for enforceQueryValues
15b839d 
Signed-off-by: Yuval Dekel <yuvddd05@gmail.com>
@yuvaldekel
feat(routes.go): add injectMatcher logging
2857c4a 
Signed-off-by: Yuval Dekel <yuvddd05@gmail.com>
@yuvaldekel
feat(routes.go, main.go): add logginf for ExtractLabel
3e8e026 
Signed-off-by: Yuval Dekel <yuvddd05@gmail.com>
@yuvaldekel
fix change sle label valuees to list
af556fb 
Signed-off-by: Yuval Dekel <yuvddd05@gmail.com>
@yuvaldekel
fix(routes_test.go): fix label enforcer test
5d98bd1 
Signed-off-by: Yuval Dekel <yuvddd05@gmail.com>
@yuvaldekel
fix syntex error
01fd1ed 
Signed-off-by: Yuval Dekel <yuvddd05@gmail.com>
@yuvaldekel
fix typo
f33b2be 
Signed-off-by: Yuval Dekel <yuvddd05@gmail.com>
@yuvaldekel
feat(enforce.go): add logging to enforce functions
47e1d17 
Signed-off-by: Yuval Dekel <yuvddd05@gmail.com>
@yuvaldekel
fix go formating error
3837744 
Signed-off-by: Yuval Dekel <yuvddd05@gmail.com>
@yuvaldekel
fix go formatting
fcc4c25 
Signed-off-by: Yuval Dekel <yuvddd05@gmail.com>
@squat

squat commented Mar 17, 2026

Copy link
Copy Markdown
Member

@yuvaldekel introducing structure logging sounds good to me. My main concern here is the use of the klog package specifically: we try to stay as close to upstream Prometheus tooling wherever possible, the the Prometheus project has standardized on the upstream Golang stdlib log/slog; could you switch this PR to use log/slog instead? If so, then it would be easier to merge this.

yuvaldekel and others added 2 commits March 20, 2026 16:25
@yuvaldekel
refactor(several): switch to slog
44fe611 
Signed-off-by: Yuval Dekel <yuvddd05@gmail.com>
@yuvaldekel
chore(deps): go mod tidy
444099d 
Signed-off-by: Yuval Dekel <yuvddd05@gmail.com>
yuvaldekel and others added 6 commits March 20, 2026 16:45
@yuvaldekel
fix(routes.go): import slog
1a4fff5 
Signed-off-by: Yuval Dekel <yuvddd05@gmail.com>
@yuvaldekel
fix(enforce.go main.go): double import
e99b10a 
Signed-off-by: Yuval Dekel <yuvddd05@gmail.com>
@yuvaldekel
fix typo enforce.go
459f3ad 
Signed-off-by: Yuval Dekel <yuvddd05@gmail.com>
@yuvaldekel
feat(main.go): nolint errcheck promslogConfig Set
3222d71 
Signed-off-by: Yuval Dekel <yuvddd05@gmail.com>
@yuvaldekel
fix(main.go) got lint fmt
485f5c9 
Signed-off-by: Yuval Dekel <yuvddd05@gmail.com>
@yuvaldekel
chore(deps): go mod tidy
e760be6 
Signed-off-by: Yuval Dekel <yuvddd05@gmail.com>
@yuvaldekel yuvaldekel changed the title feat: switch to klog and add debug logs feat: use slog and add debuging logs Mar 21, 2026
@yuvaldekel
feat(routes.go): add deafult proxy logging
3e73746 
Signed-off-by: Yuval Dekel <yuvddd05@gmail.com>
@yuvaldekel
add(routes.go): req to error handler
bd110d1 
Signed-off-by: Yuval Dekel <yuvddd05@gmail.com>
@yuvaldekel
feat(utils.go): add debug logging for api error
cba9e1d 
Signed-off-by: Yuval Dekel <yuvddd05@gmail.com>
yuvaldekel and others added 7 commits March 21, 2026 00:46
@yuvaldekel
feat(routes.go, utils.go): add dubgging logging for https requests
6788419 
Signed-off-by: Yuval Dekel <yuvddd05@gmail.com>
@yuvaldekel
fix go fmt
fac05cc 
Signed-off-by: Yuval Dekel <yuvddd05@gmail.com>
@yuvaldekel
fix go fmt
4752282 
Signed-off-by: Yuval Dekel <yuvddd05@gmail.com>
@yuvaldekel
fix undefined var
cb43490 
Signed-off-by: Yuval Dekel <yuvddd05@gmail.com>
@yuvaldekel
fix gofmt
1507588 
Signed-off-by: Yuval Dekel <yuvddd05@gmail.com>
@yuvaldekel
fix gofmt
b3cde9f 
Signed-off-by: Yuval Dekel <yuvddd05@gmail.com>
@yuvaldekel
git fmt
5f4079a 
Signed-off-by: Yuval Dekel <yuvddd05@gmail.com>
@yuvaldekel
feat(routes.go, utils.go): add r to api error
a51bb7b 
Signed-off-by: Yuval Dekel <yuvddd05@gmail.com>
@yuvaldekel
fix(routes.go): var name mistake
51439fb 
Signed-off-by: Yuval Dekel <yuvddd05@gmail.com>
@yuvaldekel
pass req to api error
9cbade5 
Signed-off-by: Yuval Dekel <yuvddd05@gmail.com>
@yuvaldekel
fix writer var name
188e281 
Signed-off-by: Yuval Dekel <yuvddd05@gmail.com>
@yuvaldekel
fix api error r name
efa2ed5 
Signed-off-by: Yuval Dekel <yuvddd05@gmail.com>
@yuvaldekel
fix syntex error
f312581 
Signed-off-by: Yuval Dekel <yuvddd05@gmail.com>
@yuvaldekel

yuvaldekel commented Mar 21, 2026

Copy link
Copy Markdown
Contributor Author

@yuvaldekel introducing structure logging sounds good to me. My main concern here is the use of the klog package specifically: we try to stay as close to upstream Prometheus tooling wherever possible, the the Prometheus project has standardized on the upstream Golang stdlib log/slog; could you switch this PR to use log/slog instead? If so, then it would be easier to merge this.

@squat switch to slog and added much more comprehensive debuging logs.
Hope it's good now. I whould be happy to get your review.

yuvaldekel and others added 4 commits April 17, 2026 23:09
@yuvaldekel
Merge branch 'main' into add-logging
91c70e7 
Signed-off-by: Yuval dekel <153660450+yuvaldekel@users.noreply.github.com>
@yuvaldekel
merge main into add-loggin
11c276c 
Signed-off-by: yuvaldekel <yuvddd05@gmail.com>
@yuvaldekel
fix syntex error
3b23f72 
Signed-off-by: yuvaldekel <yuvddd05@gmail.com>
@yuvaldekel
remove parser parsing
51ba8d9 
Signed-off-by: yuvaldekel <yuvddd05@gmail.com>
@yuvaldekel

yuvaldekel commented Apr 17, 2026

Copy link
Copy Markdown
Contributor Author

@squat Can you review it?

@yuvaldekel
Merge branch 'main' into add-logging
313ec14 
Signed-off-by: Yuval dekel <153660450+yuvaldekel@users.noreply.github.com>
simonpasquier
simonpasquier reviewed May 5, 2026
View reviewed changes

@simonpasquier simonpasquier left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To keep the change minimal, can we focus this pull request on just replacing log by log/slog? We will see after that where we would need to add new log statements.

Comment thread injectproxy/enforce.go Outdated
Comment thread main.go Outdated
@yuvaldekel

yuvaldekel commented May 5, 2026

Copy link
Copy Markdown
Contributor Author

What do you think I should remove?

@simonpasquier

simonpasquier commented May 6, 2026

Copy link
Copy Markdown
Contributor

What do you think I should remove?

Every new log statement, this PR shouldn't add/remove anything and only focus on replacing calls to log by slog.

@yuvaldekel

yuvaldekel commented May 6, 2026

Copy link
Copy Markdown
Contributor Author

What do you think I should remove?

Every new log statement, this PR shouldn't add/remove anything and only focus on replacing calls to log by slog.

I would replace log to slog and open new PR to add more logs and resolve #336

@yuvaldekel
Merge branch 'main' into add-logging
71cd28a 
Signed-off-by: Yuval dekel <153660450+yuvaldekel@users.noreply.github.com>
yuvaldekel added 2 commits May 9, 2026 13:39
@yuvaldekel
feat(main.go, injectproxy/enforce.go, injectproxy/routes.go): keep me…
bbef67f 
…rge small

Signed-off-by: yuvaldekel <yuvddd05@gmail.com>
@yuvaldekel
run go fmt
e3b8086 
Signed-off-by: yuvaldekel <yuvddd05@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@simonpasquier simonpasquier simonpasquier left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Feature Request - Add Logging

3 participants

@yuvaldekel @squat @simonpasquier