Skip to content

fix timestamp representation #1292

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 15, 2025
Merged

fix timestamp representation #1292

merged 5 commits into from
Apr 15, 2025

Conversation

zeitlinger
Copy link
Member

Fixes #1277

@zeitlinger zeitlinger self-assigned this Feb 27, 2025
@zeitlinger
Copy link
Member Author

@dhoard @fstab

this changes quite a lot - am I on the wrong track?

E.g. this would change in ExpositionFormatsTest:

image

@dhoard
Copy link
Collaborator

dhoard commented Feb 28, 2025

It feels like the correct approach to me.

@zeitlinger
Copy link
Member Author

Note: this change should only affect prom format - not openmetrics - see https://github.com/prometheus/OpenMetrics/blob/main/specification/OpenMetrics.md#timestamps

Signed-off-by: Gregor Zeitlinger <[email protected]>
Signed-off-by: Gregor Zeitlinger <[email protected]>
Signed-off-by: Gregor Zeitlinger <[email protected]>
Signed-off-by: Gregor Zeitlinger <[email protected]>
Signed-off-by: Gregor Zeitlinger <[email protected]>
@zeitlinger zeitlinger merged commit 61ae816 into main Apr 15, 2025
4 checks passed
@zeitlinger zeitlinger deleted the decimal branch April 15, 2025 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TextFormatUtil.writeTimestamp writes a value with a decimal point but the spec specifies an int64
2 participants