fix(derive-encode): expand prelude symbols to absolute paths #265
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to [1]: > Generally all macros (procedural as well as macro_rules) designed to be used > by other people should refer to every single thing in their expanded code > through an absolute path, such as std::result::Result. [1]: https://github.com/dtolnay/proc-macro-workshop/blob/3b6bcd2c3ad1c1946e6fbcc9be25d3890876087d/builder/tests/09-redefined-prelude-types.rs#L13C1-L15C58 Signed-off-by: ADD-SP <[email protected]>
ADD-SP
force-pushed
the
add_sp/fix-handle-redefined-prelude-symbols
branch
from
3793a24 to
02af0da
Compare
Signed-off-by: Max Inden <[email protected]>
ADD-SP
added a commit
to ADD-SP/client_rust
that referenced
this pull request
Apr 17, 2025
Signed-off-by: ADD-SP <[email protected]>
ADD-SP
added a commit
to ADD-SP/client_rust
that referenced
this pull request
Apr 17, 2025
Signed-off-by: ADD-SP <[email protected]>
ADD-SP
added a commit
to ADD-SP/client_rust
that referenced
this pull request
Apr 19, 2025
Signed-off-by: ADD-SP <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR expands prelude symbols like
Ok()andprometheus_clientto absolute paths to make it more hygienic.Full changes
trybuildto test procedure macro.prometheus_client::encoding::*->::prometheus_client::encoding::*std::result::Result->::core::result::Resultstd::fmt::Error->::core::fmt::ErrorOk(())->::core::result::Result::Ok(())std::fmt::Write->::core::fmt::WriteReferences
According to proc-macro-workshop:
Issues
Closes #266