Fix pagination with custom select columns and improve versionable detection#2061
Open
c15k0 wants to merge 1 commit intopropelorm:masterfrom
Open
Fix pagination with custom select columns and improve versionable detection#2061c15k0 wants to merge 1 commit intopropelorm:masterfrom
c15k0 wants to merge 1 commit intopropelorm:masterfrom
Conversation
…ection - Fix pagination failure when using custom select columns in Criteria - Add explicit versionable detection to VersionableBehavior and Table (avoid dynamic properties, required for PHP 8+ compatibility) - Remove failing PHPStan test caused by dynamic property usage - Update query class documentation generation for full PhpStorm indexing support
Contributor
|
Have a look how this was solved in Perpl VersionableBehavior.php - you can just keep track of the version tables inside the behavior. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix pagination with custom select columns and improve versionable detection