Fix path for rules_pkg providers.bzl load#230
Merged
dibenede merged 1 commit intoprotocolbuffers:mainfrom Mar 19, 2025
dibenede:fix-path
Merged
Fix path for rules_pkg providers.bzl load#230dibenede merged 1 commit intoprotocolbuffers:mainfrom dibenede:fix-path
dibenede merged 1 commit intoprotocolbuffers:mainfrom
dibenede:fix-path
Conversation
We use PackageVariablesInfo from rules_pkg for versioning. The previous change bumped the version of our rules_pkg dependency and it looks like that moved the declaring providers.bzl file change to a `pkg/` subdir. This broke our Windows builds/release automation since they use //:dist_zip. We did not catch this during PR testing because we just do `npm test`.
lukesandberg
approved these changes
Mar 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We use PackageVariablesInfo from rules_pkg for versioning. The previous change bumped the version of our rules_pkg dependency and it looks like that moved the declaring providers.bzl file change to a
pkg/subdir.This broke our Windows builds/release automation since they use //:dist_zip. We did not catch this during PR testing because we just do
npm test.