Fix error handling and resource cleanup in UPB UnknownFieldSet.#28196
Draft
copybara-service[bot] wants to merge 1 commit into
Draft
Fix error handling and resource cleanup in UPB UnknownFieldSet.#28196copybara-service[bot] wants to merge 1 commit into
copybara-service[bot] wants to merge 1 commit into
Conversation
The UPB implementation of UnknownFieldSet now correctly handles errors during the creation and appending of UnknownField objects. This includes checking the return value of PyList_Append and using Py_CLEAR instead of Py_DECREF on self->fields in error paths to prevent potential double-free issues. New tests are added to verify error propagation and resource cleanup. #12 and #13 bug in #26596 PiperOrigin-RevId: 938066907
copybara-service
Bot
force-pushed
the
test_938066907
branch
from
87ed23d to
a92ef8b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix error handling and resource cleanup in UPB UnknownFieldSet.
The UPB implementation of UnknownFieldSet now correctly handles errors during the creation and appending of UnknownField objects. This includes checking the return value of PyList_Append and using Py_CLEAR instead of Py_DECREF on self->fields in error paths to prevent potential double-free issues. New tests are added to verify error propagation and resource cleanup.
#12 and #13 bug in #26596