Add a std::function<void()> overload to protobuf generic services.#28275
Draft
copybara-service[bot] wants to merge 1 commit into
Draft
Add a std::function<void()> overload to protobuf generic services.#28275copybara-service[bot] wants to merge 1 commit into
copybara-service[bot] wants to merge 1 commit into
Conversation
copybara-service
Bot
force-pushed
the
test_940436469
branch
4 times, most recently
from
e354534 to
b22d44c
Compare
This enables the migration of service implementations away from Closure* in an incremental manner by having the std::function<void()> service implementation call the Closure* one, while the Closure* stub implementation calls the std::function<void()> stub implementation. Also delete most of protobuf callback.h stubs, which are no longer used. PiperOrigin-RevId: 940436469
copybara-service
Bot
force-pushed
the
test_940436469
branch
from
b22d44c to
d3e4ef2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a std::function<void()> overload to protobuf generic services.
This enables the migration of service implementations away from Closure* in an incremental manner by having the std::function<void()> service implementation call the Closure* one, while the Closure* stub implementation calls the std::function<void()> stub implementation.
Also delete most of protobuf callback.h stubs, which are no longer used.