clean up water logic #411
clean up water logic #411
Conversation
| var alkaline = 0; | ||
| var reservoir = 0; |
There was a problem hiding this comment.
Those are unused variables
There was a problem hiding this comment.
These properties are in tilezen, should we keep them for now and add them to the output vector tiles?
There was a problem hiding this comment.
I guess we should treat this as cleanup for now, and also investigate how the Tangram styles ever used the alkaline/reservoir properties, because if they were never symbolized we don't need them...
There was a problem hiding this comment.
I could not find the keyword alkaline in the tangrams:
https://github.com/search?q=org%3Atangrams+alkaline&type=code
lakes are there:
https://github.com/search?q=org%3Atangrams%20lake&type=code
reservoir are there too, but not as key but rather as kind value:
https://github.com/search?q=org%3Atangrams+reservoir&type=code
There was a problem hiding this comment.
It is true though that alkaline was in the tilzen tiles, for ne see:
and for osm see:
There was a problem hiding this comment.
I suggest to remove the vector tile features properties alkaline and reservoir
There was a problem hiding this comment.
Removed also the OSM reservoir / alkaline
|
CI seems to fail because it cannot find the geojson reader in planetiler. Strange... |
|
Now it says |
|
Since themeMinZoom is actually never used, there is another logic error which gets hidden by feature merge. The great lakes for example are always taken from the 10 m and the 50 m NE source layers. They appear only once in the final tiles because of feature merge post processing. But if we disable feature merge those appear twice:
|
|
Using themeMinZoom again now |
|
When preparing water unittests I noticed that there are some things to clean up in the Water.java file. For example, if one checks for sf.hasTag("name") it is not necessary to later check again for sf.getTag("name") != null...