feat: do not stask a response if response interface and error are nil

proullon · Apr 5, 2020 · 3ca400d · 3ca400d
1 parent d322afe
commit 3ca400d
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 5 deletions.
diff --git a/workerpool.go b/workerpool.go
@@ -18,6 +18,8 @@ var (
 )
 
 // JobFnc defines the job function executed by WorkerPool workers
+//
+// Note: if both response and error are nil, response will not be stacked
 type JobFnc func(payload interface{}) (response interface{}, err error)
 
 // OptFunc defines functionnal parameter to New() function
@@ -237,10 +239,12 @@ func (wp *WorkerPool) worker() {
 		wp.Done()
 		wp.tick()
 
-		wp.pushResponse(Response{
-			Body: body,
-			Err:  err,
-		})
+		if body != nil || err != nil {
+			wp.pushResponse(Response{
+				Body: body,
+				Err:  err,
+			})
+		}
 
 		if shouldExit := wp.evaluate(t, err); shouldExit {
 			return

diff --git a/workerpool_test.go b/workerpool_test.go
@@ -121,7 +121,7 @@ func TestAllIn(t *testing.T) {
 	job := &Job{}
 	wp, err := New(job.execute,
 		WithMaxWorker(1000),
-		WithEvaluationTime(2),
+		WithEvaluationTime(1),
 		WithSizePercentil(AllInSizesPercentil),
 	)