serial: Indicate gcode cmd length longer than allowed. #4168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bkerler
force-pushed
the
max_serial_cmd_length
branch
from
716aad0 to
da4e62b
Compare
CZDanol
previously approved these changes
Oct 11, 2024
bkerler
dismissed
CZDanol’s stale review
The merge-base changed after approval.
bkerler
force-pushed
the
max_serial_cmd_length
branch
from
da4e62b to
ddc31d0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refers to issue #4123.
If a gcode command being sent via serial is longer than the MAX_CMD_SIZE and the gcode command does contain a checksum, the checksum given in the command may no longer be part of the command buffer and thus leads to a checksum error although the checksum is valid.
This code adds an error if the command length exceeds the cmd buffer size and thus ensures that the checksum no longer is validated.