Rework subscription loop to use event engine #46
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Xavrax
reviewed
Mar 31, 2025
| } | ||
|
|
||
| enum pubnub_res AddListenerResult = pubnub_subscribe_add_subscription_listener(Subscription, PBSL_LISTENER_ON_MESSAGE, Callback, PubnubSubsystem); |
There was a problem hiding this comment.
Shouldn't we let developer to select kind of the listener?
There was a problem hiding this comment.
No, for default subscription loop we only use subscription listener. By this PR we replace old subscription loop with Event Engine. This is not about exposing listeners to the user.
| } | ||
|
|
||
| bool UPubnubUtilities::EEAddListenerAndSubscribe(pubnub_subscription_t* Subscription, pubnub_subscribe_message_callback_t Callback, UPubnubSubsystem* PubnubSubsystem) |
There was a problem hiding this comment.
For "Event Engine", these are internal functions not exposed to the user, so as they are directly connected to Event Engine I preferred to mark them like this.
… all requested data from server bug.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
modify(subscription): Rework subscription loop to use event engine
remove(c-core): Remove not needed c-core files from Include folder
change(params): create dedicated structures for
SortandIncludeparamsRework
GetMemberships,GetChannelMembers,GetAllUsersMetadataandandGetAllChannelsMetadatato have dedicated structures for Include and Sort fields. Note: this is BREAKING CHANGE.change(deprecate): Mark _JSON functions as deprecated
fix(fetchHistory): Fix bugs in parsing
FetchHistoryresponse.fix(responses): Fix bug that not all requested data was included in functions response when TotalCount was set.