This repository has been archived by the owner on Jun 5, 2020. It is now read-only.
use ensure_package from stdlib instead of raw package type #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @scarybot, thanks for the PR. Can you please rebase this against master? Please also check the used email address in the commit, it isn't associated with your github account. |
|
Hi - I've just fixed some conflicts, changed the email address and rebased. |
|
Hi @scarybot, the email address in the new commit isn't correct :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This module wasn't working for me due to duplicate definitions, because I'm using other modules from the forge which require ruby / rubygems packages. They're using ensure_packages() to achieve this. As you're depending on stdlib anyway, I couldn't see any harm in tweaking this module to do the same, and it's playing nicely now alongside the other modules in my environment. Let me know if this is a stupid idea!