Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

workflow fixes and improvements #88

Merged
merged 13 commits into from
May 16, 2024
Merged

workflow fixes and improvements #88

merged 13 commits into from
May 16, 2024

Conversation

h0tw1r3
Copy link
Contributor

@h0tw1r3 h0tw1r3 commented May 2, 2024

Workflows currently generate a lot of unnecessary action noise on forked repos.

  • fix current workflow is doing a "light" tag, now does an annotated tag with release notes embedded
  • adds inputs to acceptance workflow so modules (like mysql and firewall) can take advantage of these templates
  • makes labeler a reusable workflow
  • support release workflows from non-puppetlabs org (ie. puppet-toy-chest)

@h0tw1r3 h0tw1r3 added the feasture New feature or request label May 2, 2024
@h0tw1r3 h0tw1r3 requested a review from a team as a code owner May 2, 2024 20:25
@h0tw1r3
Copy link
Contributor Author

h0tw1r3 commented May 4, 2024

Tested on the puppetlabs-mysql module:
puppetlabs/puppetlabs-mysql#1629

@h0tw1r3 h0tw1r3 force-pushed the forked-modules branch 2 times, most recently from 72bdf7c to 9623061 Compare May 6, 2024 03:25
h0tw1r3 added 5 commits May 5, 2024 22:40
the previous commit fixed tagging releases with light tags
this commit supports re-tagging the old releases,
and creating releases for tags that dont have releases.
@h0tw1r3
Copy link
Contributor Author

h0tw1r3 commented May 7, 2024

Tested on puppetlabs-puppetdb, published a previously tagged but unreleased version to the forge:
https://github.com/puppetlabs/puppetlabs-puppetdb/actions/runs/8986861110

@h0tw1r3
Copy link
Contributor Author

h0tw1r3 commented May 7, 2024

Release made by workflow with updated release notes format:
https://github.com/puppetlabs/puppetlabs-puppetdb/releases/tag/v8.1.0

@h0tw1r3
Copy link
Contributor Author

h0tw1r3 commented May 7, 2024

New annotated tag example:

current

git show v8.0.1
commit 99cbeead2f7a2b2772ca59264121927e7416b1e2 (tag: v8.0.1)
Merge: 94ccecb 6fcd9cb
Author: Jeffrey Clark <[email protected]>
Date:   Thu May 2 17:55:15 2024 -0500

    Merge pull request #403 from puppetlabs/release-prep

    Release prep v8.0.1

new

$ git show v8.1.0
tag v8.1.0
Tagger: GitHub Actions <[email protected]>
Date:   Tue May 7 09:17:06 2024 -0500

- Add a  fact with PuppetDB version #404 @rwaffen
- Restrict configuration file permissions #343 @smortex
- Hide passwords from output #320 @gfa

- set encoding when creating the DB #359 @elfranne
- cron puppetdb-dlo-cleanup requires package #321 @glennaaldering

commit 0a934def95f46512d696ba4b9b0cee305fd4fe4d (HEAD -> main, tag: v8.1.0, upstream/main, origin/main, origin/HEAD)
Merge: dc991dc 335284c
Author: Jeffrey Clark <[email protected]>
Date:   Tue May 7 09:17:06 2024 -0500

    Merge pull request #405 from puppetlabs/release-prep

    Release prep v8.1.0

@h0tw1r3 h0tw1r3 changed the title Improve support for forked modules workflow fixes and improvements May 7, 2024
@h0tw1r3
Copy link
Contributor Author

h0tw1r3 commented May 7, 2024

Re-tagging workflow option with new release notes:

before workflow run

image

after workflow run

image

Copy link
Contributor

@gavindidrichsen gavindidrichsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this @h0tw1r3 !!

@h0tw1r3 h0tw1r3 merged commit c6ea797 into main May 16, 2024
2 checks passed
@h0tw1r3 h0tw1r3 deleted the forked-modules branch May 16, 2024 18:22
@h0tw1r3 h0tw1r3 mentioned this pull request Jul 10, 2024
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feasture New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants