Add base64 dependency #129
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On modern ruby, base64 moved from MRI Ruby core to a standalone gem. Without this change, we get this error: ``` lib/puppet_forge/v3/release.rb:5: warning: base64 was loaded from the standard library, but is not part of the default gems starting from Ruby 3.4.0. You can add base64 to your Gemfile or gemspec to silence this warning. ```
ekohl
reviewed
Apr 9, 2025
ekohl
approved these changes
Apr 9, 2025
ekohl
approved these changes
Apr 9, 2025
| @@ -20,16 +20,17 @@ Gem::Specification.new do |spec| | |||
|
|
|||
| spec.required_ruby_version = '>= 3.1.0' | |||
|
|
|||
| spec.add_runtime_dependency "base64", '~> 0.2.0' | |||
There was a problem hiding this comment.
There is no difference between add_runtime_dependency and add_dependency: https://guides.rubygems.org/specification-reference/#add_dependency. I don't like things having aliases, but that's Ruby for you.
There was a problem hiding this comment.
I added rubocop in #130 , to enforce a consistent style.
bastelfreak
added a commit
to bastelfreak/metadata_json_deps
that referenced
this pull request
May 5, 2025
base64 is a dependency for puppet on ruby 3.4. That's pulled in by puppet_forge. Upstream doesn't respond in puppetlabs/forge-ruby#129, so we add it here as a workaround.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On modern ruby, base64 moved from MRI Ruby core to a standalone gem.
Without this change, we get this error: