Allow piping metrics into the conversion script #25
Conversation
npwalker
force-pushed
the
allow_stdin_into_conversion
branch
2 times, most recently
from
2dc3847 to
b877431
Compare
Prior to this commit, you could not pipe output into our conversion script. The conversion script could only read files. After this commit, you can pipe output into the script OR you can read a file. You cannot pipe output in and read a file in the same invocation of the conversion script.
npwalker
force-pushed
the
allow_stdin_into_conversion
branch
from
b877431 to
64760dc
Compare
|
@reidmv I'm not entirely sure that it does work for the ./view-in_grafana.sh use case. It seems to work passing in a file and piping STDIN into the script but I was having problems with running ./view-in-grafana. I just need the STDIN part for now so I'm using these changes as my prototype over in pe_metric_curl_cron_jobs. I won't be able to dig into this for a few weeks probably. |
|
@npwalker Whats the status on this one? |
|
@jarretlavallee same as the comment above... I was having problems with it working in view-in-grafana while it was working fine directly in puppet_metrics_collector |
| @@ -333,4 +345,18 @@ def influx_metrics(data, timestamp, parent_key = nil) | |||
| end | |||
| end | |||
|
|
|||
| if ARGF.filename == '-' | |||
There was a problem hiding this comment.
This is hanging because ruby always has the option to read from STDIN. So - will be present even if you are not piping anything in. It hangs in this repo because we do not pipe anything in. Perhaps we can gate reading from STDIN on a command line argument?
|
With puppetlabs/puppetlabs-puppet_metrics_collector#19 merged, let's close this out. If you feel differently, please reopen. |
Prior to this commit, you could not pipe output into our conversion
script. The conversion script could only read files.
After this commit, you can pipe output into the script OR you can
read a file. You cannot pipe output in and read a file in the
same invocation of the conversion script.