Skip to content

Require Ruby 3.1 or newer #78

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

bastelfreak
Copy link
Contributor

Ruby 3.0 and older are EoL. Also latest PathSpec dropped support for Ruby 3.0.

Summary

Provide a detailed description of all the changes present in this pull request.

Additional Context

Add any additional context about the problem here.

  • Root cause and the steps to reproduce. (If applicable)
  • Thought process behind the implementation.

Related Issues (if any)

Mention any related issues or pull requests.

Checklist

  • 🟢 Spec tests.
  • 🟢 Acceptance tests.
  • Manually verified.

Ruby 3.0 and older are EoL. Also latest PathSpec dropped support for
Ruby 3.0.
Copy link
Member

@david22swan david22swan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately this isn't something that I think we can move forward with at this time as we require support for Puppet 7 until it is dropped, and as a consequence Ruby 2.7.

@bastelfreak
Copy link
Contributor Author

Why do you require support for Puppet 7?

@david22swan
Copy link
Member

Why do you require support for Puppet 7?

It is the current LTS Puppet Agent version and so we need to keep all of our tools compatible with it

@bastelfreak
Copy link
Contributor Author

but where does Puppet 7 rely on this tool? As far as I know you don't use it.

@david22swan
Copy link
Member

but where does Puppet 7 rely on this tool? As far as I know you don't use it.

Will bring this to the rest of the team, my first instinct is that we require support for Puppet 7 in all things however you raise an interesting point.

@ekohl
Copy link
Contributor

ekohl commented Jun 26, 2024

@bastelfreak isn't it enough to mark it compatible with the latest pathspec? Can't bundler figure it out by itself that the version needs to be downgraded?

IMHO you shouldn't do a major version bump just because you want to drop an older Ruby version, unless it gives a real advantage (like cleaning up compatibility code). Here I don't see that.

@bastelfreak
Copy link
Contributor Author

isn't it enough to mark it compatible with the latest pathspec?

We had a problem just this week where Ruby 2.7 in our zabbix module isn't able to figure this out and tries to pull in a dependency that requires a new ruby version.

I try to be very conservative with dropping stuff, but I think there it makes sense. pdk doesn't use the gem at the moment, it duplicated the code. Breaking changes in puppet-modulebuilder basically only effect Vox Pupuli / people that use our tooling. And #79 should be considered a breaking change as well. I think dropping old rubies now makes sense. We need a major release anyway, the impact to the ecosystem is quite low, it allows us to use newer dependencies.

I think it makes sense to drop the rubies now when we've the chance and not later when puppetlabs/pdk#1360 is implemented. That will cause more prolems.

@david22swan
Copy link
Member

@bastelfreak Going to give a definitive answer as this won't be merged as we have decided to go ahead with moving the PDK towards using this gem rather than its built in modulebuilder.

As such I will go ahead and close this, thank you for the work however.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants