docker::run: make systemd rate-limits configurable - #1030
Conversation
2cbc3f5 to
c436fee
Compare
|
Any feedback? |
|
Hello @tmanninger : My apologies for how long it's taken for anybody to get back to you. This looks like a good change for adding configurability to those systemd params. It looks like there are some conflicts that need to be resolved, but we'll let you know when the team can start taking a look at this PR and ask for conflict resolution at that time to ensure we're testing latest. |
|
Conflicts are solved. |
|
Thank you @tmanninger ! |
|
@jst-cyr what's the state? Can you merge it? |
|
@tmanninger : I can't personally do the merging as code owners need to get involved here. This was why I mentioned the team would ping you when the engineering team could take a look at it if there was anything else needed! I've added this PR to our tracked list (though I'll admit the list is quite long across all the modules). |
Summary
This PR makes it possible to configure systemd rate-limiting parameters (StartLimitIntervalSec and StartLimitBurst) in unit files created by docker::run.
Why is this needed?
Some container workloads may crash repeatedly on startup due to temporary conditions.
Without configurable StartLimit values, systemd may delay or prevent restarts too early.
This patch gives users control over these limits to better suit their use case.
Changes
Added two new optional parameters to docker::run:
start_limit_interval_secandstart_limit_burstAdded the same two optional parameters to the main docker class for global configuration:
start_limit_interval_secandstart_limit_burstChecklist
puppet apply)