Skip to content

docker::run: make systemd rate-limits configurable - #1030

Open
tmanninger wants to merge 1 commit into
puppetlabs:mainfrom
tmanninger:main
Open

docker::run: make systemd rate-limits configurable#1030
tmanninger wants to merge 1 commit into
puppetlabs:mainfrom
tmanninger:main

Conversation

@tmanninger

Copy link
Copy Markdown

Summary

This PR makes it possible to configure systemd rate-limiting parameters (StartLimitIntervalSec and StartLimitBurst) in unit files created by docker::run.

Why is this needed?

Some container workloads may crash repeatedly on startup due to temporary conditions.
Without configurable StartLimit values, systemd may delay or prevent restarts too early.
This patch gives users control over these limits to better suit their use case.

Changes

Added two new optional parameters to docker::run:
start_limit_interval_sec and start_limit_burst

Added the same two optional parameters to the main docker class for global configuration:
start_limit_interval_sec and start_limit_burst

Checklist

  • 🟢 Spec tests.
  • 🟢 Acceptance tests.
  • Manually verified. (For example puppet apply)

@tmanninger
tmanninger requested a review from a team as a code owner August 29, 2025 11:49
@CLAassistant

CLAassistant commented Aug 29, 2025

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@tmanninger
tmanninger force-pushed the main branch 2 times, most recently from 2cbc3f5 to c436fee Compare September 1, 2025 08:12
@tmanninger

Copy link
Copy Markdown
Author

Any feedback?

@jst-cyr

jst-cyr commented Jun 30, 2026

Copy link
Copy Markdown
Member

Hello @tmanninger : My apologies for how long it's taken for anybody to get back to you. This looks like a good change for adding configurability to those systemd params. It looks like there are some conflicts that need to be resolved, but we'll let you know when the team can start taking a look at this PR and ask for conflict resolution at that time to ensure we're testing latest.

@tmanninger

Copy link
Copy Markdown
Author

Conflicts are solved.

@jst-cyr

jst-cyr commented Jul 3, 2026

Copy link
Copy Markdown
Member

Thank you @tmanninger !

@tmanninger

Copy link
Copy Markdown
Author

@jst-cyr what's the state? Can you merge it?

@jst-cyr

jst-cyr commented Jul 15, 2026

Copy link
Copy Markdown
Member

@tmanninger : I can't personally do the merging as code owners need to get involved here. This was why I mentioned the team would ping you when the engineering team could take a look at it if there was anything else needed! I've added this PR to our tracked list (though I'll admit the list is quite long across all the modules).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants